Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 #6157

Closed
wants to merge 1 commit into from
Closed

Remove upper bounds on cuda-python to allow 12.6.2 and 11.8.5 #6157

wants to merge 1 commit into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 4, 2024

Now that some upstream bugs have been fixed, we can allow cuda-python 12.6.2 and 11.8.5.

See NVIDIA/cuda-python#226 (comment) for more information.

@bdice bdice added non-breaking Non-breaking change feature request New feature or request labels Dec 4, 2024
@github-actions github-actions bot added the conda conda issue label Dec 4, 2024
@bdice bdice mentioned this pull request Dec 4, 2024
Open
@bdice bdice marked this pull request as ready for review December 4, 2024 05:32
@bdice bdice requested a review from a team as a code owner December 4, 2024 05:32
@bdice bdice requested a review from msarahan December 4, 2024 05:32
@dantegd
Copy link
Member

dantegd commented Dec 4, 2024

@bdice the dask related errors are unrelated to the PR, we're looking into them

@jameslamb jameslamb removed the request for review from msarahan December 4, 2024 17:23
@jameslamb jameslamb mentioned this pull request Dec 5, 2024
Merged
@jameslamb
Copy link
Member

Now that rmm and cudf nightlies were built against newer cuda-python, I think we might need BOTH fixes for the Dask issues and this PR to unblock 25.02 CI here.

ref: #6149 (comment)

wphicks
wphicks approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, and I also confirmed that this fixes the issue I was seeing locally with a missing module on cudf import.

@bdice
Copy link
Contributor Author

bdice commented Dec 6, 2024

Closing in favor of #6166.

@bdice bdice closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
conda conda issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @dantegd @jameslamb @wphicks