Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve dependency-file-generator warning, other rapids-build-backend followup #5928

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

#5804 was one of the earlier rapids-build-backend PRs merged across RAPIDS. Since it was merged, we've made some small adjustments to the approach for rapids-build-backend. This catches cuml up with those changes:

  • removes unused constants in ci/build* scripts
  • uses --file-key instead of --file_key in rapids-dependency-file-generator calls
  • uses --prepend-channel instead of --prepend-channels in rapids-dependency-file-generator calls
  • ensures ci/update-version.sh preserves alpha specs

@jameslamb jameslamb added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 12, 2024
@github-actions github-actions bot added the ci label Jun 12, 2024
@jameslamb jameslamb changed the title WIP: resolve dependency-file-generator warning, other rapids-build-backend followup resolve dependency-file-generator warning, other rapids-build-backend followup Jun 14, 2024
@jameslamb jameslamb added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Jun 14, 2024
@jameslamb jameslamb marked this pull request as ready for review June 14, 2024 14:42
@jameslamb jameslamb requested a review from a team as a code owner June 14, 2024 14:42
@jameslamb jameslamb requested a review from raydouglass June 14, 2024 14:42
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 6342914 into rapidsai:branch-24.08 Jun 14, 2024
60 of 62 checks passed
@jameslamb jameslamb deleted the more-rbb branch June 14, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants