Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated API in notebook #5862

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

rjzamora
Copy link
Member

Minor notebook change. Motivated by rapidsai/cudf#15592

@taureandyernv - Just an FYI: I'm sure there is plenty of example code/documentation floating around that uses dask_cudf.to/from_dask_dataframe. I will be looking for this, and changing it to *.to_backend("cudf"/"pandas"). Feel free to point out problem areas :)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 24, 2024
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any other occurrence of the deprecated APIs on a quick search across the codebase, I'm a bit surprised! LGTM

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 24, 2024
@dantegd
Copy link
Member

dantegd commented Apr 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 429a80e into rapidsai:branch-24.06 Apr 25, 2024
59 checks passed
@rjzamora rjzamora deleted the use-to-backend branch April 25, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants