Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --rm and --name to devcontainer run args #5857

Merged
merged 3 commits into from
Apr 23, 2024
Merged

add --rm and --name to devcontainer run args #5857

merged 3 commits into from
Apr 23, 2024

Conversation

trxcllnt
Copy link
Collaborator

  • Update the cuda11.8-conda devcontainer's base image
  • Remove the devcontainer when the VSCode window closes
  • Adds a descriptive name to the running container: 
    $ docker ps -a
CONTAINER ID   IMAGE         ...  NAMES
0dbb364fe544   vsc-cuml-...  ...  rapids-cuml-24.06-cuda12.2-conda

$ docker rm -f rapids-cuml-24.06-cuda12.2-conda

@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 19, 2024
@trxcllnt trxcllnt mentioned this pull request Apr 19, 2024
Merged
@trxcllnt trxcllnt requested a review from a team as a code owner April 22, 2024 17:17
@github-actions github-actions bot added the ci label Apr 22, 2024
@dantegd
Copy link
Member

dantegd commented Apr 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit ef39b85 into rapidsai:branch-24.06 Apr 23, 2024
59 checks passed
@dantegd dantegd mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trxcllnt @dantegd @AyodeAwe