Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cudf.Index instead of cudf.GenericIndex. #5738

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 31, 2024

I saw the cuml docs build failed, with the error below:

Failed to import cuml.compose.
Possible hints:
* AttributeError: module 'cudf' has no attribute 'GenericIndex'
* KeyError: 'cuml'

This is due to pandas 2 changes in cudf that need updated in cuml. This PR is unlikely to contain the full changeset of things needed for pandas 2 support, but it fixes one problem and we can let CI tell us the rest of the failures.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 31, 2024
@bdice
Copy link
Contributor Author

bdice commented Jan 31, 2024

As expected, there are lots of test failures due to the pandas 2 changes in cudf. However, this change did fix the docs build! 😄 Maybe we can admin-merge this and let the test failures be addressed in a later PR?

@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change labels Feb 1, 2024
@raydouglass raydouglass marked this pull request as ready for review February 1, 2024 17:26
@raydouglass raydouglass requested a review from a team as a code owner February 1, 2024 17:26
@raydouglass raydouglass merged commit 40b5581 into rapidsai:branch-24.04 Feb 1, 2024
44 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants