[LogisticRegressionMG][FEA] Support training when dataset contains only one class #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijinf2
force-pushed
the
fea_lrmg_onelabel
branch
from
4324d4d to
56f00c4
Compare
lijinf2
added
non-breaking
lijinf2
force-pushed
the
fea_lrmg_onelabel
branch
2 times, most recently
from
2adfc37 to
7d5c635
Compare
|
/ok to test |
csadorf
requested changes
Nov 28, 2023
Comment on lines
400
to
401
| if not isinstance(cu_preds, np.ndarray): | ||
| cu_preds = cu_preds.to_numpy() |
There was a problem hiding this comment.
What do we expect there? Sparse arrays?
There was a problem hiding this comment.
cu_preds stores predicted labels in a dense array or cudf.
lijinf2
force-pushed
the
fea_lrmg_onelabel
branch
2 times, most recently
from
2cc76f5 to
ce40be2
Compare
lijinf2
force-pushed
the
fea_lrmg_onelabel
branch
from
ce40be2 to
1bc15ec
Compare
csadorf
approved these changes
Nov 28, 2023
csadorf
approved these changes
Nov 28, 2023
cjnolet
approved these changes
Nov 29, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality for C++ training on datasets with a single label. It helps Spark Rapids ML match Spark's behavior. Additionally, it updates the Dask class to generate an error message, consistent with Scikit-learn's behavior.
This PR depends on #5632