CI: Fix expected ValueError and dask-glm incompatibility #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
csadorf
commented
Nov 6, 2023
•
csadorf
commented
- Expect all supported types and shapes to work with host mem type.
- Pin dask-glm to 0.3.0.
And repurpose related test.
csadorf
added
bug
github-actions
bot
added
conda
csadorf
changed the title
csadorf
commented
Nov 8, 2023
| # TODO: remove pin once a release that includes fixes for the error | ||
| # is released: https://github.com/rapidsai/cuml/issues/5514 | ||
| - hdbscan<=0.8.30 | ||
| - output_types: pyproject | ||
| packages: | ||
| - dask-glm @ git+https://github.com/dask/dask-glm@main | ||
| - dask-glm==0.3.0 | ||
| # TODO: Can we stop pulling from the master branch now that there was a release in October? |
There was a problem hiding this comment.
I think comment technically belongs to the dask-glm, but I'm hesitant to delay merge of this.
AyodeAwe
approved these changes
Nov 8, 2023
dantegd
approved these changes
Nov 8, 2023
|
/merge |
csadorf
deleted the
fix/do-not-expect-value-error-for-support-host-dtypes-and-array-shapes
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.