Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuml-cpu notebook, docs and cluster models #5597

Merged
merged 15 commits into from
Oct 6, 2023
Merged

cuml-cpu notebook, docs and cluster models #5597

merged 15 commits into from
Oct 6, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Oct 2, 2023 •
edited
Loading

PR does two things:

  • Adds cuml-cpu notebook
  • Adds cluster models to cuml-cpu package

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added Cython / Python Cython or Python issue CMake labels Oct 5, 2023
@dantegd dantegd added the 3 - Ready for Review Ready for review by team label Oct 5, 2023
@dantegd dantegd marked this pull request as ready for review October 5, 2023 12:37
@dantegd dantegd requested review from a team as code owners October 5, 2023 12:37
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 5, 2023
@dantegd dantegd changed the title cuml-cpu notebook, docs and improvements cuml-cpu notebook, docs and cluster models Oct 5, 2023
wphicks
wphicks approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the new notebook! No substantive comments or requests for changes; just found one dead link. Pre-approving.

docs/source/execution_device_interoperability.ipynb Outdated Show resolved Hide resolved
docs/source/execution_device_interoperability.ipynb Outdated Show resolved Hide resolved
cjnolet
cjnolet approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really just a very minor nitpick in wording, but LGTM!

docs/source/execution_device_interoperability.ipynb Outdated Show resolved Hide resolved
@dantegd
Copy link
Member Author

dantegd commented Oct 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0dbb8c1 into rapidsai:branch-23.10 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CMake Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantegd @cjnolet @wphicks