Remove raft specializations includes. #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
Tech Debt
cjnolet
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
LGTM. Thanks so much @bdice for fixing this! No doubt @ahendriksen has really made the use of libraft super easy on downstream users.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins to address a large number of deprecations in RAFT that cause large build logs for libcuml. I tackled only the easiest ones in this PR, where it was a simple change or removal of an
#include. It seems like the work for the other deprecations will be more substantial.This fixes deprecations like the one below. I will file a separate issue for the remaining deprecations.