Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing RAFT cusolver_macros import and changes for recent cuDF updates #5434

Merged
merged 18 commits into from
May 26, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/src_prims/sparse/batched/csr.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <cuml/common/utils.hpp>

#include <linalg/batched/matrix.cuh>
#include <raft/core/cusolver_macros.hpp>
#include <raft/matrix/matrix.cuh>
#include <raft/util/cudart_utils.hpp>
#include <rmm/device_uvector.hpp>
Expand Down
5 changes: 2 additions & 3 deletions python/cuml/feature_extraction/_vectorizers.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def get_char_ngrams(self, ngram_size, str_series, doc_id_sr):
meaning we need to first tokenize and pad each token with a delimiter.
"""
if self.analyzer == "char_wb" and ngram_size != 1:
token_count = str_series.str.token_count(self.delimiter)
token_count = str_series.str.token_count(delimiter=self.delimiter)
tokens = str_series.str.tokenize(self.delimiter)
del str_series

Expand Down Expand Up @@ -598,7 +598,7 @@ def fit_transform(self, raw_documents, y=None):
if self._fixed_vocabulary:
self.vocabulary_ = self.vocabulary
else:
self.vocabulary_ = tokenized_df["token"].unique()
self.vocabulary_ = tokenized_df["token"].unique().sort_values()

count_df = self._count_vocab(tokenized_df)

Expand Down Expand Up @@ -804,7 +804,6 @@ class HashingVectorizer(_VectorizerMixin):
... ]
>>> vectorizer = HashingVectorizer(n_features=2**4)
>>> X = vectorizer.fit_transform(pd.Series(corpus))
>>> print(X.shape)
bdice marked this conversation as resolved.
Show resolved Hide resolved
(4, 16)

See Also
Expand Down