Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HDBSCAN runner to work with latest RAFT #5425

Closed
wants to merge 3 commits into from
Closed

Update HDBSCAN runner to work with latest RAFT #5425

wants to merge 3 commits into from

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented May 18, 2023 •
edited
Loading

Fix build error

[17/120] Building CUDA object CMakeFiles/cuml++.dir/src/hdbscan/hdbscan.cu.o
FAILED: CMakeFiles/cuml++.dir/src/hdbscan/hdbscan.cu.o
/home/nfs/phcho/mambaforge/envs/cuml_dev/include/raft/distance/detail/fused_distance_nn/predicated_tile_iterator_reduced_vec.h(240): error: no instance of overloaded function "ML::HDBSCAN::FixConnectivitiesRedOp<value_idx, value_t>::init [with value_idx=int, value_t=float]" matches the argument list and object (the object has type qualifiers that prevent a match)
argument types are: (raft::KeyValuePair<int, float> *, const float)
object type is: const ML::HDBSCAN::FixConnectivitiesRedOp<int, float>

@hcho3 hcho3 requested a review from a team as a code owner May 18, 2023 01:07
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels May 18, 2023
cjnolet
cjnolet approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending passing CI

@cjnolet
Copy link
Member

cjnolet commented May 18, 2023

/merge

@mdoijade mdoijade mentioned this pull request May 18, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request May 18, 2023
@mdoijade
Fix kmeans pytest to correctly compute fp output error (#5426)
dd432c6 
-- This PR is on top build fix - #5425
-- fixes the fp error checking logic and set the tolerance to account for 3xTF32 based fusedL2NN kernel

Authors:
  - Mahesh Doijade (https://github.com/mdoijade)
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5426
@github-actions github-actions bot removed the CUDA/C++ label May 25, 2023
@hcho3 hcho3 closed this May 25, 2023
@hcho3
Copy link
Contributor Author

hcho3 commented May 25, 2023

Superceded by #5426

@hcho3 hcho3 deleted the fix_build_hdbscan branch May 25, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @cjnolet