Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cupy dependency #5401

Merged
merged 5 commits into from
May 4, 2023
Merged

Update cupy dependency #5401

merged 5 commits into from
May 4, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 3, 2023

Switch to requiring cupy 12

@vyasr vyasr requested review from a team as code owners May 3, 2023 22:48
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 3, 2023
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels May 3, 2023
dantegd
dantegd approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, seems we're just missing having cudf wheels updated before CI passes?

@vyasr
Copy link
Contributor Author

vyasr commented May 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit 80c0c4b into rapidsai:branch-23.06 May 4, 2023
@vyasr vyasr deleted the chore/update_cupy_12 branch May 4, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @dantegd @AyodeAwe