Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Update MST Reduction Op #5386

Merged

Conversation

tarang-jain
Copy link
Contributor

@tarang-jain tarang-jain commented Apr 24, 2023

Make HDBSCAN MST reduction operation compatible with #1445 raft PR. This PR updates the Mutual Reachability reduction op in HDBSCAN in the following ways:

  1. Colors information is no longer needed in the reduction op because the new mst implementation in raft ensures that distances between points of the same color are not computed.
  2. Adds gather and scatter functions to rearrange the core distances within the reduction op so that they are aligned with the sort-plan wherein rows in the input matrix and core distances are rearranged so that the training data points are sorted by color.
    Closes [FEA] Make FixConnectivitiesRedOp Compatible with Masked NN for building MST #5456

@tarang-jain tarang-jain self-assigned this May 19, 2023
@tarang-jain tarang-jain added the breaking Breaking change label May 19, 2023
@tarang-jain tarang-jain added the feature request New feature or request label May 19, 2023
@github-actions github-actions bot added ci CMake conda conda issue Cython / Python Cython or Python issue labels Jun 3, 2023
@tarang-jain tarang-jain changed the base branch from branch-23.06 to branch-23.08 June 3, 2023 00:10
@github-actions github-actions bot removed ci CMake conda conda issue labels Jun 3, 2023
@github-actions github-actions bot removed the Cython / Python Cython or Python issue label Jun 3, 2023
@tarang-jain tarang-jain marked this pull request as ready for review June 3, 2023 00:35
@tarang-jain tarang-jain requested a review from a team as a code owner June 3, 2023 00:35
@tarang-jain tarang-jain added the 5 - Merge After Dependencies Depends on another PR: do not merge out of order label Jun 5, 2023
@tarang-jain tarang-jain added non-breaking Non-breaking change and removed breaking Breaking change labels Jun 23, 2023
@tarang-jain tarang-jain requested a review from a team as a code owner July 24, 2023 22:52
@github-actions github-actions bot added the CMake label Jul 24, 2023
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending revert of get_raft.cmake

@github-actions github-actions bot removed the CMake label Jul 25, 2023
@cjnolet
Copy link
Member

cjnolet commented Jul 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit cfa5020 into rapidsai:branch-23.08 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Merge After Dependencies Depends on another PR: do not merge out of order CUDA/C++ feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Make FixConnectivitiesRedOp Compatible with Masked NN for building MST
3 participants