Correct buffer move assignment in experimental FIL #5372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
added
bug
divyegala
reviewed
May 22, 2023
| { | ||
| swap(*this, other); | ||
| auto copy = other; |
There was a problem hiding this comment.
Is this not a recursive call?
There was a problem hiding this comment.
Nope, this is equivalent to:
buffer<T> copy{other};
That is to say, it invokes the copy constructor, not the copy assignment operator.
divyegala
approved these changes
May 23, 2023
|
/merge |
dantegd
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A last-minute change to the buffer implementation caused the move assignment operator to not be invoked correctly where it should be allowed. This PR updates the implementation, avoiding unnecessary copies for buffers. It also adds C++ tests for buffer.