Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run dask tests twice when testing wheels #5279

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Mar 16, 2023

The wheel unittest CI was running the dask tests twice in GHA. Fix by adjusting the pytest --ignore param to work like pytest expects.

The wheel unittest CI was running the dask tests twice in GHA. Fix
by adjusting the pytest `--ignore` param to work like pytest expects.
@benfred benfred requested a review from a team as a code owner March 16, 2023 22:12
@benfred
Copy link
Member Author

benfred commented Mar 16, 2023

You can see the dask tests running twice in logs like https://github.com/rapidsai/cuml/actions/runs/4412150319/jobs/7731536409 -

with

2023-03-14T05:07:59.9552965Z [gw1] [ 94%] PASSED python/cuml/tests/dask/test_dask_nearest_neighbors.py::test_compare_skl[10-False-1-10-5-10-300] 

being reported by the first run (thats using pytest-xdist) and

2023-03-14T05:56:05.5596040Z python/cuml/tests/dask/test_dask_nearest_neighbors.py::test_compare_skl[10-False-1-10-5-10-300] PASSED [ 86%]

being reported by the second pass thats only running the dask tests

With this change - this test should only be run once.

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Mar 16, 2023
@cjnolet
Copy link
Member

cjnolet commented Mar 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 417a36e into rapidsai:branch-23.04 Mar 17, 2023
@benfred benfred deleted the dask_ci_tweak branch March 17, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants