[REVIEW] Docs build script for cuML [skip ci] #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2019 14:15
cjnolet
added
2 - In Progress
cjnolet
added
3 - Ready for Review
dantegd
requested changes
May 2, 2019
ci/docs/build.sh
Outdated
| @@ -0,0 +1,92 @@ | |||
| #!/bin/bash | |||
| # Copyright (c) 2018, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2018, NVIDIA CORPORATION. | |
| # Copyright (c) 2018-2019, NVIDIA CORPORATION. |
ci/docs/build.sh
Outdated
| logger "Activate conda env..." | ||
| source activate gdf | ||
| conda install -c rapidsai/label/cuda$CUDA_REL -c rapidsai-nightly/label/cuda$CUDA_REL -c conda-forge \ | ||
| cudf=$CUDF_VERSION rmm=$RMM_VERSION |
There was a problem hiding this comment.
Would we need to install cudatoolkit due to #533 ?
There was a problem hiding this comment.
I believe that is only for conda builds? It wasn't added to our gpu script. @raydouglass can you confirm if this is needed or not?
added 2 commits
May 2, 2019 13:02
dantegd
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script for nightly doc builds.