Allowing large data in kmeans #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
divyegala
approved these changes
Feb 11, 2023
ajschmidt8
force-pushed
the
branch-23.04
branch
from
6f2fda7 to
20d2690
Compare
Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4007
Really, this is just an intermediate solution until we properly handle the cases when nrows*ncols > 2*31-1 internally
Co-authored-by: Divye Gala <[email protected]>
cjnolet
force-pushed
the
bug-2304-kmeans_64bit_int
branch
from
10ece34 to
74431dd
Compare
cjnolet
added
bug
dantegd
approved these changes
Feb 14, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat of an intermediate solution to fix an issue w/ kmeans that is currently prohibiting the algorithm from working when n_rows * n_cols > 2^32-1.
For now, using 64-bit indexing allows the algorithm to work. We need to dig in further on the raft side to figure out where the numerical issue is happening. So far, some of this has to do w/ the new APIs we created and how it's handling indexing.