Forward-merge branch-23.02 to branch-23.04 #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~~The X input in `fit` and `fit_transform` functions is unnecessary when a KNN graph is provided. This PR adds a `precomputed` boolean parameter. It specifies whether X would serve as a classic input or as a precomputed KNN graph. Additional the `transform` function is modified so that it cannot take a KNN graph anymore.~~
This PR does the following :
1) Provides a `precomputed_knn` parameter to UMAP and tSNE constructor.
It can be provided in the form of a :
- tuple (distances, indices)
- pairwise distance matrix of shape (n_samples, n_samples)
- KNN graph in CSR/COO/CSC format
2) Makes the legacy `knn_graph` parameter of the UMAP and tSNE fit method capable of taking in all the forms aforementioned. The `knn_graph` parameter when provided would take precedence over the `precomputed_knn` parameter.
3) Removes `knn_graph` parameter from UMAP transform method as it wasn't actually doing anything.
4) Adds precomputed KNN capabilities for the UMAP fit method in the sparse case.
Authors:
- Victor Lafargue (https://github.com/viclafargue)
- Dante Gama Dessavre (https://github.com/dantegd)
- Corey J. Nolet (https://github.com/cjnolet)
Approvers:
- Corey J. Nolet (https://github.com/cjnolet)
URL: #4865
|
SUCCESS - forward-merge complete. |
AyodeAwe
pushed a commit
to AyodeAwe/cuml
that referenced
this pull request
Feb 13, 2023
Forward-merge branch-23.02 to branch-23.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-23.02that creates a PR to keepbranch-23.04up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.