Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase margin for flaky FIL test #5194

Merged
merged 8 commits into from
Feb 3, 2023
Merged

Increase margin for flaky FIL test #5194

merged 8 commits into from
Feb 3, 2023

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Feb 2, 2023

No description provided.

@wphicks wphicks requested a review from a team as a code owner February 2, 2023 16:36
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 2, 2023
@wphicks wphicks added bug Something isn't working non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Feb 2, 2023
@wphicks
Correct pytest skip decorator
4b127a4
@wphicks
Merge flaky test PRs to pass CI
99f26bb 
Merge branch 'bug-disable_pairwise_kernels_test2' into bug-2302_flaky_fil
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 2, 2023
@wphicks wphicks mentioned this pull request Feb 2, 2023
Closed
@codecov-commenter
Copy link

Codecov Report

Base: 67.11% // Head: 67.21% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (99f26bb) compared to base (85b33df).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #5194      +/-   ##
================================================
+ Coverage         67.11%   67.21%   +0.10%     
================================================
  Files               192      192              
  Lines             12396    12370      -26     
================================================
- Hits               8320     8315       -5     
+ Misses             4076     4055      -21
Impacted Files Coverage Δ
python/cuml/dask/common/input_utils.py 34.37% <0.00%> (-1.51%) ⬇️
python/cuml/dask/ensemble/randomforestregressor.py 33.87% <0.00%> (-1.05%) ⬇️
...ython/cuml/dask/ensemble/randomforestclassifier.py 29.88% <0.00%> (-0.80%) ⬇️
python/cuml/preprocessing/TargetEncoder.py 85.22% <0.00%> (-0.08%) ⬇️
...on/cuml/benchmark/automated/bench_random_forest.py 0.00% <0.00%> (ø)
python/cuml/dask/preprocessing/label.py 40.00% <0.00%> (+0.71%) ⬆️
...ython/cuml/dask/neighbors/kneighbors_classifier.py 23.42% <0.00%> (+1.57%) ⬆️
python/cuml/dask/neighbors/nearest_neighbors.py 28.75% <0.00%> (+2.00%) ⬆️
python/cuml/dask/neighbors/kneighbors_regressor.py 32.75% <0.00%> (+2.11%) ⬆️
python/cuml/common/kernel_utils.py 95.83% <0.00%> (+4.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Feb 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8ceafc3 into rapidsai:branch-23.02 Feb 3, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@wphicks
Increase margin for flaky FIL test (rapidsai#5194)
a480150 
Authors:
  - William Hicks (https://github.com/wphicks)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wphicks @codecov-commenter @dantegd @cjnolet