Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin wheel dependencies to same RAPIDS release #5183

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Pin wheel dependencies to same RAPIDS release #5183

merged 4 commits into from
Feb 2, 2023

Conversation

sevagh
Copy link
Contributor

@sevagh sevagh commented Jan 31, 2023

Now that wheel CI is enabled, the nightly index will contain next release wheels, so we need to ensure those don't get installed while still building this release.

@sevagh sevagh requested review from a team as code owners January 31, 2023 16:45
@github-actions github-actions bot added ci Cython / Python Cython or Python issue labels Jan 31, 2023
@sevagh sevagh added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuml also needs the custom backend updated in python/_custom_build/backend.py

@sevagh sevagh requested a review from a team as a code owner January 31, 2023 19:13
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! You still have to update the copyright year in the update-version.sh script.

@codecov-commenter
Copy link

Codecov Report

Base: 67.12% // Head: 67.12% // No change to project coverage 👍

Coverage data is based on head (3f13c7a) compared to base (f6abf81).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #5183   +/-   ##
=============================================
  Coverage         67.12%   67.12%           
=============================================
  Files               192      192           
  Lines             12396    12396           
=============================================
  Hits               8321     8321           
  Misses             4075     4075           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr
Copy link
Contributor

vyasr commented Feb 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit 85b33df into rapidsai:branch-23.02 Feb 2, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Now that wheel CI is enabled, the nightly index will contain next release wheels, so we need to ensure those don't get installed while still building this release.

Authors:
  - Sevag H (https://github.com/sevagh)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Carl Simon Adorf (https://github.com/csadorf)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants