Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting RAFT pin #5178

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jan 30, 2023

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 30, 2023
@cjnolet cjnolet requested a review from a team as a code owner January 30, 2023 22:41
@cjnolet cjnolet self-assigned this Jan 30, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 69.26% // Head: 67.12% // Decreases project coverage by -2.15% ⚠️

Coverage data is based on head (965d97c) compared to base (de32125).
Patch coverage: 24.44% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5178      +/-   ##
================================================
- Coverage         69.26%   67.12%   -2.15%     
================================================
  Files               192      192              
  Lines             12333    12396      +63     
================================================
- Hits               8543     8321     -222     
- Misses             3790     4075     +285     
Impacted Files Coverage Δ
python/cuml/testing/strategies.py 33.76% <19.04%> (-60.31%) ⬇️
...ing/text/stem/porter_stemmer_utils/suffix_utils.py 91.11% <100.00%> (+0.20%) ⬆️
python/cuml/neighbors/kernel_density.py 52.59% <0.00%> (-35.07%) ⬇️
python/cuml/metrics/pairwise_kernels.py 70.07% <0.00%> (-11.03%) ⬇️
python/cuml/testing/utils.py 78.63% <0.00%> (-10.39%) ⬇️
python/cuml/internals/memory_utils.py 78.18% <0.00%> (-8.19%) ⬇️
python/cuml/internals/array.py 81.62% <0.00%> (-6.53%) ⬇️
python/cuml/feature_extraction/_vectorizers.py 84.38% <0.00%> (-5.65%) ⬇️
python/cuml/dask/neighbors/kneighbors_regressor.py 30.64% <0.00%> (-2.12%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8
Copy link
Member

/merge

Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msadang msadang merged commit 4c1ec7b into rapidsai:branch-23.02 Feb 1, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants