Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update location of import_utils from common to internals for Forest notebook #5171

Merged
merged 2 commits into from
Jan 31, 2023
Merged

[REVIEW] Update location of import_utils from common to internals for Forest notebook #5171

merged 2 commits into from
Jan 31, 2023

Conversation

taureandyernv
Copy link
Contributor

@taureandyernv taureandyernv commented Jan 27, 2023 •
edited
Loading

Closes #5172

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 27, 2023
@taureandyernv taureandyernv mentioned this pull request Jan 27, 2023
Closed
@taureandyernv
Copy link
Contributor Author

@dantegd @cjnolet , Tried to update the branch, as per Github's suggestions to pass the checks, and it requires and authorized user. Can one of you do it and add the labels, as I don't have that level of access?

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2023
@dantegd
Copy link
Member

dantegd commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit d42c093 into rapidsai:branch-23.02 Jan 31, 2023
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@taureandyernv
Update location of import_utils from common to internals for Fo…
b21d466 
…rest notebook (rapidsai#5171)

Closes rapidsai#5172

Authors:
  - Taurean Dyer (https://github.com/taureandyernv)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@taureandyernv taureandyernv

Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Update import_utils location in Forest notebook
3 participants
@taureandyernv @dantegd @cjnolet