Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gather_if raft update #5149

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix gather_if raft update #5149

merged 1 commit into from
Jan 23, 2023

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jan 23, 2023

No description provided.

@lowener lowener requested a review from a team as a code owner January 23, 2023 16:04
@lowener lowener added bug Something isn't working non-breaking Non-breaking change CUDA/C++ and removed CUDA/C++ labels Jan 23, 2023
@lowener
Copy link
Contributor Author

lowener commented Jan 23, 2023

@Nyrio this is a follow-up to rapidsai/raft#1126

@Nyrio
Copy link
Contributor

Nyrio commented Jan 23, 2023

Oh, size() is size_t and breaks template type inference? Sorry for missing that.

@cjnolet
Copy link
Member

cjnolet commented Jan 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit de32125 into rapidsai:branch-23.02 Jan 23, 2023
@lowener lowener deleted the 23.02-gatherif branch January 24, 2023 10:19
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@lowener
Fix gather_if raft update (rapidsai#5149)
775ee29 
Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#5149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@lowener lowener

Labels
bug Something isn't working CUDA/C++ non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lowener @Nyrio @cjnolet