Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated raft headers #5134

Merged
merged 10 commits into from
Jan 31, 2023

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jan 17, 2023

@lowener lowener requested review from a team as code owners January 17, 2023 20:31
@lowener lowener added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 17, 2023
FORK rapidsai
PINNED_TAG branch-${CUML_BRANCH_VERSION_raft}
FORK lowener
PINNED_TAG 23.02-rm-depr
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to change this

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending cmake revert

@github-actions github-actions bot removed the CMake label Jan 20, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 69.63% // Head: 69.02% // Decreases project coverage by -0.61% ⚠️

Coverage data is based on head (70f18c3) compared to base (1bf8f57).
Patch coverage: 95.60% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5134      +/-   ##
================================================
- Coverage         69.63%   69.02%   -0.61%     
================================================
  Files               192      192              
  Lines             12523    12333     -190     
================================================
- Hits               8720     8513     -207     
- Misses             3803     3820      +17     
Impacted Files Coverage Δ
python/cuml/internals/__init__.py 100.00% <ø> (ø)
python/cuml/internals/api_decorators.py 97.59% <95.60%> (+1.52%) ⬆️
python/cuml/neighbors/kernel_density.py 74.02% <0.00%> (-13.64%) ⬇️
python/cuml/internals/array.py 87.35% <0.00%> (-0.80%) ⬇️
python/cuml/metrics/pairwise_kernels.py 80.31% <0.00%> (-0.79%) ⬇️
python/cuml/testing/utils.py 88.72% <0.00%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 5754774 into rapidsai:branch-23.02 Jan 31, 2023
@lowener lowener deleted the 23.02-raft-headers branch January 31, 2023 22:54
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants