Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly lower the test_mbsgd_regressor expected min score. #5092

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Slightly lower the test_mbsgd_regressor expected min score. #5092

merged 2 commits into from
Dec 15, 2022

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Dec 15, 2022

To unblock CI.

@csadorf csadorf requested a review from a team as a code owner December 15, 2022 13:56
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 15, 2022
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Dec 15, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 15, 2022
@wphicks
Copy link
Contributor

wphicks commented Dec 15, 2022

@gpucibot merge

@csadorf csadorf mentioned this pull request Dec 15, 2022
Merged
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@cbfc1ba). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head d232976 differs from pull request most recent head 1b46311. Consider uploading reports for the commit 1b46311 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.02    #5092   +/-   ##
===============================================
  Coverage                ?   79.69%           
===============================================
  Files                   ?      184           
  Lines                   ?    11852           
  Branches                ?        0           
===============================================
  Hits                    ?     9446           
  Misses                  ?     2406           
  Partials                ?        0
Flag Coverage Δ
dask 45.80% <0.00%> (?)
non-dask 69.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit 38dea2f into rapidsai:branch-23.02 Dec 15, 2022
@csadorf csadorf deleted the enh-lower-test_mbsgd_regressor-test_expected_min_score branch December 16, 2022 08:56
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@csadorf
Slightly lower the test_mbsgd_regressor expected min score. (rapidsai…
cf69ffb 
…#5092)

To unblock CI.

Authors:
  - Carl Simon Adorf (https://github.com/csadorf)

Approvers:
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#5092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csadorf @wphicks @codecov-commenter