Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide workaround for kernel ridge solver #5064

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Provide workaround for kernel ridge solver #5064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa5b096
Demonstrate workaround for kernel ridge solver
wphicks Nov 28, 2022
5ced541
Add comment justifying workaround
wphicks Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/cuml/kernel_ridge/kernel_ridge.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ def _safe_solve(K, y):
err_mode = geterr()["linalg"]
seterr(linalg="raise")
dual_coef = lapack.posv(K, y)
# Perform following check as a workaround for cusolver issue to be
# fixed in a future CUDA version
wphicks marked this conversation as resolved.
Show resolved Hide resolved
if cp.all(cp.isnan(dual_coef)):
wphicks marked this conversation as resolved.
Show resolved Hide resolved
raise np.linalg.LinAlgError
seterr(linalg=err_mode)
except np.linalg.LinAlgError:
warnings.warn(
Expand Down