Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move single test from test to tests #5037

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Move single test from test to tests #5037

merged 1 commit into from
Dec 7, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 30, 2022

All tests of cuML but one are in the same directory. This moves that one test and removes the now empty directory.

@vyasr vyasr added 3 - Ready for Review Ready for review by team tests Unit testing for project Tech Debt Issues related to debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 30, 2022
@vyasr vyasr requested a review from a team as a code owner November 30, 2022 18:18
@vyasr vyasr self-assigned this Nov 30, 2022
@vyasr vyasr requested review from a team as code owners November 30, 2022 18:18
@vyasr vyasr changed the base branch from branch-22.12 to branch-23.02 November 30, 2022 18:18
@github-actions github-actions bot added CMake CUDA/C++ Cython / Python Cython or Python issue labels Nov 30, 2022
@vyasr vyasr removed request for a team November 30, 2022 18:19
@vyasr vyasr added CMake and removed CMake labels Nov 30, 2022
wphicks
wphicks approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A useful zero-byte change? Sign me up!

@wphicks
Copy link
Contributor

wphicks commented Nov 30, 2022

@gpucibot merge

@csadorf csadorf added the 0 - Blocked Cannot progress due to external reasons label Dec 7, 2022
@csadorf
Copy link
Contributor

csadorf commented Dec 7, 2022

Blocked by #5051 .

csadorf
csadorf approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😁

@csadorf csadorf removed the 0 - Blocked Cannot progress due to external reasons label Dec 7, 2022
@csadorf
Copy link
Contributor

csadorf commented Dec 7, 2022

rerun tests

@csadorf csadorf added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 7, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@29ef1a5). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.02    #5037   +/-   ##
===============================================
  Coverage                ?   79.69%           
===============================================
  Files                   ?      184           
  Lines                   ?    11707           
  Branches                ?        0           
===============================================
  Hits                    ?     9330           
  Misses                  ?     2377           
  Partials                ?        0
Flag Coverage Δ
dask 46.00% <0.00%> (?)
non-dask 69.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member

cjnolet commented Dec 7, 2022

@gpucibot merge

@ajschmidt8 ajschmidt8 changed the title Move single test from test to tests Move single test from test to tests Dec 7, 2022
@rapids-bot rapids-bot bot merged commit 64de061 into rapidsai:branch-23.02 Dec 7, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@vyasr
Move single test from test to tests (rapidsai#5037)
d849979 
All tests of cuML but one are in the same directory. This moves that one test and removes the now empty directory.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Carl Simon Adorf (https://github.com/csadorf)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#5037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@csadorf csadorf csadorf approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Tech Debt Issues related to debt tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @wphicks @csadorf @codecov-commenter @cjnolet