Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] [skip-ci] Assign python/ sub-directory to python-codeowners #4940

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Oct 21, 2022

This ensures that all files within the python/ sub-directory have a codeowner assigned.

Special files like the python/setup.py file that is declared later will still be owned by @rapidsai/cuml-cmake-codeowners .

This ensures that all files within the python/ sub-directory have a codeowner
assigned.

Special files like the python/setup.py file that is declared later will still
be owned by @rapidsai/cuml-cmake-codeowners .
@csadorf csadorf requested a review from a team as a code owner October 21, 2022 12:18
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Oct 21, 2022
@csadorf csadorf changed the title [REVIEW] Assign python/ sub-directory to python-codeowners [REVIEW] [skipci] Assign python/ sub-directory to python-codeowners Oct 21, 2022
@csadorf csadorf changed the title [REVIEW] [skipci] Assign python/ sub-directory to python-codeowners [REVIEW] [skip-ci] Assign python/ sub-directory to python-codeowners Oct 21, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@aa3693f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #4940   +/-   ##
===============================================
  Coverage                ?   79.46%           
===============================================
  Files                   ?      183           
  Lines                   ?    11618           
  Branches                ?        0           
===============================================
  Hits                    ?     9232           
  Misses                  ?     2386           
  Partials                ?        0           
Flag Coverage Δ
dask 46.10% <0.00%> (?)
non-dask 68.92% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sean-frye sean-frye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csadorf
Copy link
Contributor Author

csadorf commented Oct 25, 2022

@gpucibot merge

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Oct 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 68cc06f into rapidsai:branch-22.12 Oct 25, 2022
@csadorf csadorf deleted the fix-python-codeowners branch October 25, 2022 12:11
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This ensures that all files within the python/ sub-directory have a codeowner assigned.

Special files like the python/setup.py file that is declared later will still be owned by @rapidsai/cuml-cmake-codeowners .

Authors:
  - Carl Simon Adorf (https://github.com/csadorf)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Sean Frye (https://github.com/sean-frye)

URL: rapidsai#4940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants