Update KMeans notebook for clarity #4886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dantegd
approved these changes
Sep 25, 2022
|
rerun tests |
3 similar comments
|
rerun tests |
|
rerun tests |
|
rerun tests |
|
@gpucibot merge |
Codecov ReportBase: 78.02% // Head: 79.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #4886 +/- ##
================================================
+ Coverage 78.02% 79.35% +1.33%
================================================
Files 180 181 +1
Lines 11385 11540 +155
================================================
+ Hits 8883 9158 +275
+ Misses 2502 2382 -120
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
This PR updates the existing KMeans notebook to improve clarity and make the performance benefit clear. Closes rapidsai#4135 Authors: - Nick Becker (https://github.com/beckernick) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the existing KMeans notebook to improve clarity and make the performance benefit clear.
Closes #4135