Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin dask and distributed for release #4859

Merged
merged 19 commits into from
Oct 4, 2022
Merged

[REVIEW] Pin dask and distributed for release #4859

merged 19 commits into from
Oct 4, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 8, 2022 •
edited
Loading

This PR pins dask & distributed to 2022.9.2 for 22.10 release.

xref: rapidsai/cudf#11492
xref: rapidsai/cudf#11822

@galipremsagar galipremsagar requested a review from a team as a code owner August 8, 2022 15:51
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Aug 8, 2022
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 8, 2022
@galipremsagar galipremsagar self-assigned this Aug 8, 2022
@galipremsagar
Copy link
Contributor Author

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor Author

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Aug 26, 2022 •
edited
Loading

@dantegd | @cjnolet Can someone take a look at cuml dask-related test failures?, this seems to be blocking.

@dantegd
Copy link
Member

dantegd commented Aug 31, 2022

rerun tests

@galipremsagar
Copy link
Contributor Author

Seems like there are pytest failures:

[Test Result](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/) (5 failures / +5)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_inverse_transform[None]](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_inverse_transform_None_/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_inverse_transform[first]](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_inverse_transform_first_/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_inverse_transform[drop2]](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_inverse_transform_drop2_/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_drop_idx_first](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_drop_idx_first/)
[cuml.tests.dask.test_dask_one_hot_encoder.test_onehot_drop_one_of_each](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/2650/testReport/junit/cuml.tests.dask/test_dask_one_hot_encoder/test_onehot_drop_one_of_each/)

@galipremsagar
Copy link
Contributor Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Sep 28, 2022

@quasiben @galipremsagar working on a small fix for the CI tests errors that are happening, will push them shortly

galipremsagar
galipremsagar commented Sep 29, 2022
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
conda/environments/cuml_dev_cuda11.0.yml Outdated Show resolved Hide resolved
conda/environments/cuml_dev_cuda11.2.yml Outdated Show resolved Hide resolved
conda/environments/cuml_dev_cuda11.4.yml Outdated Show resolved Hide resolved
conda/environments/cuml_dev_cuda11.5.yml Outdated Show resolved Hide resolved
conda/recipes/cuml/meta.yaml Outdated Show resolved Hide resolved
@galipremsagar galipremsagar changed the title [REVIEW] Unpin dask and distributed for development [REVIEW] Pin dask and distributed for release Sep 29, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Sep 29, 2022
@galipremsagar galipremsagar added the DO NOT MERGE Hold off on merging; see PR for details label Sep 30, 2022
@galipremsagar
Copy link
Contributor Author

Tagging this PR with DONOT MERGE because we are waiting on a new dask release 2022.9.2 which will be out tomorrow.

galipremsagar
galipremsagar commented Sep 30, 2022
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
galipremsagar
galipremsagar commented Sep 30, 2022
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from a team as a code owner September 30, 2022 22:20
@galipremsagar galipremsagar removed the DO NOT MERGE Hold off on merging; see PR for details label Sep 30, 2022
@galipremsagar
Copy link
Contributor Author

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Oct 4, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

Base: 79.35% // Head: 79.35% // No change to project coverage 👍

Coverage data is based on head (5750683) compared to base (96da84c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-22.10    #4859   +/-   ##
=============================================
  Coverage         79.35%   79.35%           
=============================================
  Files               181      181           
  Lines             11540    11540           
=============================================
  Hits               9158     9158           
  Misses             2382     2382
Flag Coverage Δ
dask 46.02% <ø> (ø)
non-dask 68.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit 550a326 into rapidsai:branch-22.10 Oct 4, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@galipremsagar
Pin dask and distributed for release (rapidsai#4859)
9f72cae 
This PR pins `dask` & `distributed` to `2022.9.2` for `22.10` release.

~~xref: rapidsai/cudf#11492
xref: rapidsai/cudf#11822

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@galipremsagar galipremsagar

Labels
conda conda issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@galipremsagar @ajschmidt8 @dantegd @quasiben @cjnolet @codecov-commenter @raydouglass