-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forward-merge conflicts #4857
Merged
ajschmidt8
merged 7 commits into
rapidsai:branch-22.10
from
ajschmidt8:fix-merge-conflicts
Aug 5, 2022
Merged
Fix forward-merge conflicts #4857
ajschmidt8
merged 7 commits into
rapidsai:branch-22.10
from
ajschmidt8:fix-merge-conflicts
Aug 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR does the required changes for Scikit-build using RAPIDS-CMake. - [x] Update .gitignore - [x] Create `python/cuml/CMakeLists.txt` file - [x] Add `CMakeLists.txt` using RAPIDS-CMake to Python folders - [x] Update `setup.py` - [x] Update `build.sh` - [x] Update CI files - [x] Update conda env files - [x] Clean code Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) - Sevag H (https://github.com/sevagh) - Vyas Ramasubramani (https://github.com/vyasr) - Robert Maynard (https://github.com/robertmaynard) URL: #4818
This PR pins `dask` & `distributed` to `2022.7.1` for `22.08` release. xref: rapidsai/cudf#11433 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - AJ Schmidt (https://github.com/ajschmidt8) URL: #4850
With this PR, the feature sampling overhead is greatly reduced, especially for wide (thousands of features) datasets. The PR requires some structural changes in RAFT therefore is marked as WIP. Authors: - Vinay Deshpande (https://github.com/vinaydes) - Ray Douglass (https://github.com/raydouglass) - Andy Adinets (https://github.com/canonizer) - Jordan Jacobelli (https://github.com/Ethyling) - Jiwei Liu (https://github.com/daxiongshu) - GALI PREM SAGAR (https://github.com/galipremsagar) - Christopher Akiki (https://github.com/cakiki) - Venkat (https://github.com/venkywonka) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4278
This PR will utilize the common css & js code being merged here: rapidsai/docs#286 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4844
This PR makes a switch to utilizing common `js` & `css` code and defer's loading of custom js. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #4852
ajschmidt8
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Aug 5, 2022
github-actions
bot
added
CMake
conda
conda issue
CUDA/C++
Cython / Python
Cython or Python issue
gpuCI
gpuCI issue
labels
Aug 5, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #4857 +/- ##
===============================================
Coverage ? 78.02%
===============================================
Files ? 180
Lines ? 11385
Branches ? 0
===============================================
Hits ? 8883
Misses ? 2502
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
Fix forward-merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
conda
conda issue
CUDA/C++
Cython / Python
Cython or Python issue
gpuCI
gpuCI issue
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the conflicts in #4849.