Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KNN cython object use __dealloc__ instead of __del__ #4831

Closed
wants to merge 2 commits into from
Closed

Make KNN cython object use __dealloc__ instead of __del__ #4831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcf3ead
Make KNN cython object use __dealloc__ instead of __del__
achirkin Jul 26, 2022
d0a0a4e
Update get_raft.cmake
achirkin Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/cmake/thirdparty/get_raft.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ endfunction()
# To use a different RAFT locally, set the CMake variable
# CPM_raft_SOURCE=/path/to/local/raft
find_and_configure_raft(VERSION ${CUML_MIN_VERSION_raft}
FORK rapidsai
PINNED_TAG branch-${CUML_BRANCH_VERSION_raft}
FORK achirkin
PINNED_TAG e6a815bdaa10a520da94088dbeb4b4d4b6da4e07

# When PINNED_TAG above doesn't match cuml,
# force local raft clone in build directory
Expand Down
2 changes: 1 addition & 1 deletion python/cuml/neighbors/nearest_neighbors.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ class NearestNeighbors(Base,

return sparse_csr

def __del__(self):
def __dealloc__(self):
cdef knnIndex* knn_index = <knnIndex*>0
cdef BallCoverIndex* rbc_index = <BallCoverIndex*>0

Expand Down