Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplicial set functions #4756

Merged
merged 16 commits into from
May 31, 2022
Merged

Simplicial set functions #4756

merged 16 commits into from
May 31, 2022

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested review from a team as code owners May 24, 2022 15:03
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels May 24, 2022
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 26, 2022
@github-actions github-actions bot added gpuCI gpuCI issue and removed CUDA/C++ labels May 27, 2022
@cjnolet
Copy link
Member

cjnolet commented May 27, 2022

rerun tests

@viclafargue viclafargue requested a review from a team as a code owner May 27, 2022 14:11
@cjnolet
Copy link
Member

cjnolet commented May 27, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@b37a968). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #4756   +/-   ##
===============================================
  Coverage                ?   79.93%           
===============================================
  Files                   ?      180           
  Lines                   ?    11379           
  Branches                ?        0           
===============================================
  Hits                    ?     9096           
  Misses                  ?     2283           
  Partials                ?        0
Flag Coverage Δ
dask 45.50% <0.00%> (?)
non-dask 69.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37a968...4b356dd. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented May 30, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented May 31, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2a14d70 into rapidsai:branch-22.06 May 31, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Simplicial set functions (rapidsai#4756)
8d8eedb 
Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Sevag Hanssian (https://github.com/sevagh)

URL: rapidsai#4756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevagh sevagh sevagh approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @cjnolet @codecov-commenter @sevagh