Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KBinsDiscretizer bin_edges_ #4735

Merged
merged 3 commits into from
May 31, 2022
Merged

Fix KBinsDiscretizer bin_edges_ #4735

merged 3 commits into from
May 31, 2022

Conversation

viclafargue
Copy link
Contributor

Fixes #4617

@viclafargue viclafargue requested a review from a team as a code owner May 16, 2022 16:18
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 16, 2022
@viclafargue viclafargue force-pushed the fix-kbinsdiscretizer-bin-edges branch from d62c43e to cec1b57 Compare May 16, 2022 16:57
lowener
lowener reviewed May 16, 2022
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, can you update the docstring to use cupy instead of numpy as well?

lowener
lowener approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels May 23, 2022
@viclafargue
Copy link
Contributor Author

rerun tests

cjnolet
cjnolet approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented May 23, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

Merging #4735 (eb1d6e0) into branch-22.06 (15aba09) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06    #4735      +/-   ##
================================================
+ Coverage         79.89%   79.92%   +0.03%     
================================================
  Files               180      180              
  Lines             11371    11384      +13     
================================================
+ Hits               9085     9099      +14     
+ Misses             2286     2285       -1
Flag Coverage Δ
dask 45.50% <42.85%> (+0.04%) ⬆️
non-dask 69.56% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hirdparty/sklearn/preprocessing/_discretization.py 83.72% <100.00%> (+0.38%) ⬆️
python/cuml/preprocessing/LabelEncoder.py 93.24% <0.00%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15aba09...eb1d6e0. Read the comment docs.

@rapids-bot rapids-bot bot merged commit c1b4fbe into rapidsai:branch-22.06 May 31, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Fix KBinsDiscretizer bin_edges_ (rapidsai#4735)
3f197cb 
Fixes rapidsai#4617

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Micka (https://github.com/lowener)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowener lowener lowener approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] KBinsDiscretizer bin_edges attribute error when used with cupy input
4 participants
@viclafargue @cjnolet @codecov-commenter @lowener