Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enabling raft NVTX markers when raft is installed #4718

Merged
merged 2 commits into from
May 12, 2022
Merged

Allow enabling raft NVTX markers when raft is installed #4718

merged 2 commits into from
May 12, 2022

Conversation

achirkin
Copy link
Contributor

@achirkin achirkin commented May 2, 2022

Adjust the name of the option according to the changes proposed in rapidsai/raft#610

@achirkin achirkin requested a review from a team as a code owner May 2, 2022 08:04
@achirkin achirkin added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed CMake CUDA/C++ labels May 2, 2022
@achirkin achirkin mentioned this pull request May 2, 2022
Merged
@achirkin
Copy link
Contributor Author

achirkin commented May 5, 2022

rerun tests

@achirkin
Copy link
Contributor Author

achirkin commented May 6, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented May 12, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@6ca7254). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #4718   +/-   ##
===============================================
  Coverage                ?   79.89%           
===============================================
  Files                   ?      180           
  Lines                   ?    11371           
  Branches                ?        0           
===============================================
  Hits                    ?     9085           
  Misses                  ?     2286           
  Partials                ?        0
Flag Coverage Δ
dask 45.45% <0.00%> (?)
non-dask 69.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca7254...892c613. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented May 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d01c591 into rapidsai:branch-22.06 May 12, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@achirkin
Allow enabling raft NVTX markers when raft is installed (rapidsai#4718)
e671fc8 
Adjust the name of the option according to the changes proposed in rapidsai/raft#610

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achirkin @cjnolet @codecov-commenter