Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample_weight for Ridge #4696

Merged
merged 8 commits into from
May 27, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Apr 11, 2022

No description provided.

@lowener lowener requested review from a team as code owners April 11, 2022 11:57
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Apr 11, 2022
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 23, 2022
@lowener lowener added the 3 - Ready for Review Ready for review by team label May 24, 2022
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good overall. Suggesting just a couple very minor things but I think it's likely this can make it into 22.06.

cpp/src/glm/ridge.cuh Show resolved Hide resolved
cpp/src/glm/ridge.cuh Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented May 26, 2022

rerun tests

2 similar comments
@cjnolet
Copy link
Member

cjnolet commented May 26, 2022

rerun tests

@lowener
Copy link
Contributor Author

lowener commented May 26, 2022

rerun tests

@lowener
Copy link
Contributor Author

lowener commented May 26, 2022

Encountered this CI error:
cuml.tests.test_kernel_ridge.test_pairwise_kernels (from pytest)

test_kernel_ridge.py:177: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

kernel_arg = ('cosine', {}), XY = (array([[7.940934e-23]], dtype=float32), None)

    @given(kernel_arg_strategy(), array_strategy())
    @settings(deadline=None)
    def test_pairwise_kernels(kernel_arg, XY):
        X, Y = XY
        kernel, args = kernel_arg
        K = pairwise_kernels(X, Y, metric=kernel, **args)
        skl_kernel = kernel.py_func if hasattr(kernel, "py_func") else kernel
        K_sklearn = skl_pairwise_kernels(
            *as_type('numpy', X, Y), metric=skl_kernel, **args)
>       assert np.allclose(as_type('numpy', K), K_sklearn, atol=0.01, rtol=0.01)
E       AssertionError: assert False
E        +  where False = <function allclose at 0x7f9a3c0a2940>(array([[1.]], dtype=float32), array([[1.1250001]], dtype=float32), atol=0.01, rtol=0.01)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@70105ad). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #4696   +/-   ##
===============================================
  Coverage                ?   79.93%           
===============================================
  Files                   ?      180           
  Lines                   ?    11379           
  Branches                ?        0           
===============================================
  Hits                    ?     9096           
  Misses                  ?     2283           
  Partials                ?        0           
Flag Coverage Δ
dask 45.50% <0.00%> (?)
non-dask 69.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70105ad...b317875. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented May 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b37a968 into rapidsai:branch-22.06 May 27, 2022
@lowener lowener deleted the 22.06-ridge-weight branch May 27, 2022 12:30
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants