-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Enable building static libs #4673
[FEA] Enable building static libs #4673
Conversation
All static code that will be embedded in to a shared library needs to be compiled with |
rerun tests |
@gpucibot merge |
rerun tests |
rerun tests |
Not sure what this is about, but this seems unrelated to this PR:
|
rerun tests |
rerun tests |
1 similar comment
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #4673 +/- ##
===============================================
Coverage ? 79.89%
===============================================
Files ? 181
Lines ? 11370
Branches ? 0
===============================================
Hits ? 9084
Misses ? 2286
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This reverts commit 61524d7.
This PR allows building libcuml++ static libs via CMake option `-DBUILD_SHARED_LIBS=ON|OFF`. ~I was seeing a linker error due to not having `-fPIC` enabled, but I wouldn't have expected this to affect static libs. I'll investigate some more and turn it off if possible, but for now `-fPIC` is enabled.~ Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4673
This PR allows building libcuml++ static libs via CMake option
-DBUILD_SHARED_LIBS=ON|OFF
.I was seeing a linker error due to not having-fPIC
enabled, but I wouldn't have expected this to affect static libs. I'll investigate some more and turn it off if possible, but for now-fPIC
is enabled.