Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OOM and cudaContext crash in C++ benchmarks #4594

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

RAMitchell
Copy link
Contributor

Fix #4525 as well as a hard crash in c++ benchmarks due to some recent changes in raft.

@RAMitchell RAMitchell requested a review from a team as a code owner February 21, 2022 16:34
@dantegd
Copy link
Member

dantegd commented Feb 24, 2022

rerun tests

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 24, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@9e0d458). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4594   +/-   ##
===============================================
  Coverage                ?   84.02%           
===============================================
  Files                   ?      250           
  Lines                   ?    20303           
  Branches                ?        0           
===============================================
  Hits                    ?    17059           
  Misses                  ?     3244           
  Partials                ?        0           
Flag Coverage Δ
dask 44.93% <0.00%> (?)
non-dask 77.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0d458...a0c4f0a. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented Feb 24, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 35d3c0a into rapidsai:branch-22.04 Feb 24, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Fix rapidsai#4525 as well as a hard crash in c++ benchmarks due to some recent changes in raft.

Authors:
  - Rory Mitchell (https://github.com/RAMitchell)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] C++ benchmarks memory leak
4 participants