Automatically clone raft when branch pin changes #4592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
|
rerun tests |
|
Merged into #4593. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that RAFT has official conda packages, it'll be much easier to work locally on cuml features that rely on the RAFT nightly.
Working on features that span raft and cuml should be fairly straightforward to do locally as well, because CPM provides the
CPM_raft_SOURCEvariable that can passed into thecmakecall to tell the build to use a local working copy of RAFT.Now that cuml's CI has a direct dependency on RAFT conda packages, updating the raft pinned tag in
get_raft.cmakewill no longer work. The option added in this PR will force clone a local version of the pinned tag (both locally and in CI) and set theCPM_raft_SOURCEto that path.