Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QN solver to ElasticNet and Lasso models #4576

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

achirkin
Copy link
Contributor

Add an alternative (Quasi-Newton) solver to ElasticNet and Lasso models. It may be faster for some input sizes.

@achirkin achirkin requested a review from a team as a code owner February 14, 2022 12:46
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 14, 2022
@achirkin achirkin added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Feb 14, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 14, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@9e0d458). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4576   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20052           
  Branches                ?        0           
===============================================
  Hits                    ?    16819           
  Misses                  ?     3233           
  Partials                ?        0           
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.96% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0d458...d4c40d5. Read the comment docs.

@achirkin achirkin added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Feb 14, 2022
@achirkin achirkin requested a review from tfeher February 15, 2022 09:10
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition!

@dantegd
Copy link
Member

dantegd commented Feb 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1f3ccdf into rapidsai:branch-22.04 Feb 15, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Add an alternative (Quasi-Newton) solver to ElasticNet and Lasso models. It may be faster for some input sizes.

Authors:
  - Artem M. Chirkin (https://github.com/achirkin)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants