Fix RF integer overflow #4563
Merged
Fix RF integer overflow #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinaydes @venkywonka would be great if you can give a short review. |
venkywonka
approved these changes
Feb 8, 2022
venkywonka
added
the
improvement
cjnolet
approved these changes
Feb 8, 2022
|
rerun tests |
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #4563 +/- ##
===============================================
Coverage ? 85.73%
===============================================
Files ? 239
Lines ? 19585
Branches ? 0
===============================================
Hits ? 16792
Misses ? 2793
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
The following script results in an illegal memory access: ```python import cupy as cp from cuml.ensemble import RandomForestClassifier X = cp.random.random((1000000, 2500),dtype=cp.float32) assert(X.size > 2**31) y = cp.zeros(X.shape[0]) y[::2]=1.0 model = RandomForestClassifier() model.fit(X,y) pred = model.predict(X) ``` Fixed by some targeted casting of integers to 64 bit. See rapidsai#2459. Authors: - Rory Mitchell (https://github.com/RAMitchell) Approvers: - Venkat (https://github.com/venkywonka) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following script results in an illegal memory access:
Fixed by some targeted casting of integers to 64 bit.
See #2459.