Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Remove xfail from test_hinge_loss #4504

Merged
merged 2 commits into from
Feb 12, 2022
Merged

[REVIEW] Remove xfail from test_hinge_loss #4504

merged 2 commits into from
Feb 12, 2022

Conversation

Nanthini10
Copy link
Contributor

Closes #3569
The test passes and does not need the xfail decorator.

@Nanthini10 Nanthini10 requested review from a team as code owners January 21, 2022 22:52
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue labels Jan 21, 2022
@Nanthini10 Nanthini10 added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change tests Unit testing for project bug Something isn't working and removed gpuCI gpuCI issue conda conda issue CMake CUDA/C++ labels Jan 21, 2022
@Nanthini10 Nanthini10 changed the base branch from branch-22.02 to branch-22.04 January 21, 2022 22:55
@Nanthini10 Nanthini10 mentioned this pull request Jan 21, 2022
Open
@ajschmidt8 ajschmidt8 removed the request for review from a team January 24, 2022 15:41
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

cjnolet
cjnolet approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI (looks like the copyright needs updating).

@dantegd
Copy link
Member

dantegd commented Feb 11, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@25c93a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4504   +/-   ##
===============================================
  Coverage                ?   83.87%           
===============================================
  Files                   ?      250           
  Lines                   ?    20070           
  Branches                ?        0           
===============================================
  Hits                    ?    16833           
  Misses                  ?     3237           
  Partials                ?        0
Flag Coverage Δ
dask 45.18% <0.00%> (?)
non-dask 76.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c93a6...94b7187. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Feb 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9e0d458 into rapidsai:branch-22.04 Feb 12, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@Nanthini10
Remove xfail from test_hinge_loss (rapidsai#4504)
7977374 
Closes rapidsai#3569 
The test passes and does not need the xfail decorator.

Authors:
  - Nanthini (https://github.com/Nanthini10)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CI failures on test_hinge_loss
5 participants
@Nanthini10 @ajschmidt8 @dantegd @codecov-commenter @cjnolet