[WIP] Accept fold index for TargetEncoder #4453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with upstream
sync with upstream
sync with upstream
Sync with upstream
sync with upstream
sync with upstream
merge with upstream
sync with upstream
|
stop |
daxiongshu
added
non-breaking
dantegd
requested changes
Jan 13, 2022
| @@ -114,7 +118,7 @@ def __init__(self, n_folds=4, smooth=0, seed=42, | |||
| self.train = None | |||
| self.output_type = output_type | |||
|
|
|||
| def fit(self, x, y): | |||
| def fit(self, x, y, fold_ids=None): | |||
There was a problem hiding this comment.
Can you add fold_ids to the docstring?
There was a problem hiding this comment.
yeah, thank you for comments.
| self.train_encode = res | ||
| self.train = train | ||
| self._fitted = True | ||
| return self | ||
|
|
||
| def fit_transform(self, x, y): | ||
| def fit_transform(self, x, y, fold_ids=None): |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #4453 +/- ##
===============================================
Coverage ? 85.74%
===============================================
Files ? 236
Lines ? 19322
Branches ? 0
===============================================
Hits ? 16567
Misses ? 2755
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
approved these changes
Jan 20, 2022
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
As requested in issue rapidsai#4441, in this PR we let TargetEncoder accept a customized fold index array in `fit()` For example, in the following code ``` X = [1, 2, 3, 1, 2] y = [1, 0, 0, 0, 1] fold_id = [0,1,0,0,1] encoder = TargetEncoder(split_method='customize') encoder.fit(X,y,fold_id=fold_id) ``` The target encoder will fit subarray of `X` and `y` where `fold_id==0` to encode the subarray of `X` where `fold_id==1`, and vice versa. Authors: - Jiwei Liu (https://github.com/daxiongshu) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in issue #4441, in this PR we let TargetEncoder accept a customized fold index array in
fit()For example, in the following code
The target encoder will fit subarray of
Xandywherefold_id==0to encode the subarray ofXwherefold_id==1, and vice versa.