Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sample_weights in LinearRegression #4428
Add support for sample_weights in LinearRegression #4428
Changes from 4 commits
1451325
99cdebe
1827795
ae8b24e
463c158
f58a8a7
f47e360
65630b1
8090895
e81980c
68146e9
b8c7092
dd92cdf
7bae2af
f6e8c33
6e35d8d
da761af
df297c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something you need to change in this PR, but it would be nice to start adopting
std::optional
for arguments like these. Becomes self-documenting as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree so I started to make the change but I saw that
std::optional
support on Cython is very recent and will be added to version0.30
. For the moment we're using version0.29
so the adoption ofstd::optional
on Python-facing functions should maybe wait a bit more.