Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dense and sparse tests #4417

Merged
merged 34 commits into from
Dec 18, 2021
Merged

Conversation

levsnv
Copy link
Contributor

@levsnv levsnv commented Dec 2, 2021

The pull request includes changes from #4328. To view only changes pertinent to unifying tests, see
https://github.com/levsnv/cuml/pull/3/files?diff=unified&w=1

@levsnv levsnv requested a review from a team as a code owner December 2, 2021 00:21
@levsnv levsnv requested a review from canonizer December 2, 2021 00:21
Copy link
Contributor

@canonizer canonizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Approved, provided that the comments are addressed.

Review details in levsnv#3.

@levsnv levsnv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 16, 2021
@levsnv levsnv added the 3 - Ready for Review Ready for review by team label Dec 17, 2021
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! LGTM

@wphicks
Copy link
Contributor

wphicks commented Dec 17, 2021

@gpucibot merge

@levsnv levsnv removed the 3 - Ready for Review Ready for review by team label Dec 17, 2021
@levsnv
Copy link
Contributor Author

levsnv commented Dec 18, 2021

rerun tests

15:16:13 gpuCI logger » [12/17/21 23:16:14]
15:16:13 ┌─────────────────────────────────────────┐
15:16:13 |    Checking if ccache tarball exists    |
15:16:13 └─────────────────────────────────────────┘
15:16:13 

15:16:15 {
15:16:15     "AcceptRanges": "bytes",
15:16:15     "Expiration": "expiry-date=\"Mon, 17 Jan 2022 00:00:00 GMT\", rule-id=\"Delete data after 30 days\"",
15:16:15     "LastModified": "2021-12-17T23:12:25+00:00",
15:16:15     "ContentLength": 4286279680,
15:16:15     "ETag": "\"1e56c0a4b48a05f1495ff8f324a1934c\"",
15:16:15     "ContentType": "binary/octet-stream",
15:16:15     "ServerSideEncryption": "AES256",
15:16:15     "Metadata": {}
15:16:15 }
15:16:15 Found existing ccache tarball: rapidsai/cuml/pull-request/4417/ccache/ccache-ubuntu18.04-cuda11.5-py3.7-aarch64.tar
15:16:36 tar: Skipping to next header
15:16:42 tar: Exiting with failure status due to previous errors
15:16:42 Build step 'Execute shell' marked build as failure
15:17:02 [Set GitHub commit status (universal)] ERROR on repos [GHRepository@1bba4d9d[nodeId=MDEwOlJlcG9zaXRvcnkxNTI2MTY4MDI=,description=cuML - RAPIDS Machine Learning Library,homepage=,name=cuml,fork=false,archived=false,size=152711,milestones={},language=Cuda,commits={},source=<null>,parent=<null>,isTemplate=false,url=https://api.github.com/repos/rapidsai/cuml,id=152616802,nodeId=<null>,createdAt=2018-10-11T15:45:35Z,updatedAt=2021-12-17T21:30:16Z]] (sha:5679fe1) with context:gpuCI/cuml/build/python-arm64/3.7/cuda/11.5

@rapids-bot rapids-bot bot merged commit 81648cb into rapidsai:branch-22.02 Dec 18, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
The pull request includes changes from rapidsai#4328. To view only changes pertinent to unifying tests, see
https://github.com/levsnv/cuml/pull/3/files?diff=unified&w=1

Authors:
  - Levs Dolgovs (https://github.com/levsnv)

Approvers:
  - Andy Adinets (https://github.com/canonizer)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants