Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Using sparse public API functions from RAFT #4389

Merged
merged 9 commits into from
Dec 7, 2021
Merged

[REVIEW] Using sparse public API functions from RAFT #4389

merged 9 commits into from
Dec 7, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 18, 2021

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 18, 2021
@cjnolet cjnolet requested review from a team as code owners November 18, 2021 22:05
@ajschmidt8
Copy link
Member

rerun tests

@github-actions github-actions bot removed the conda conda issue label Nov 19, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Nov 19, 2021

rerun tests

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 23, 2021
@ajschmidt8 ajschmidt8 removed the request for review from a team November 29, 2021 20:01
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@cjnolet
Copy link
Member Author

cjnolet commented Nov 30, 2021

rerun tests

4 similar comments
@cjnolet
Copy link
Member Author

cjnolet commented Dec 2, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 2, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 6, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Dec 6, 2021

rerun tests

divyegala
divyegala approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CMake label Dec 7, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Dec 7, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@2a2e3b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4389   +/-   ##
===============================================
  Coverage                ?   85.73%           
===============================================
  Files                   ?      236           
  Lines                   ?    19314           
  Branches                ?        0           
===============================================
  Hits                    ?    16558           
  Misses                  ?     2756           
  Partials                ?        0
Flag Coverage Δ
dask 46.52% <0.00%> (?)
non-dask 78.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2e3b3...92669a8. Read the comment docs.

@rapids-bot rapids-bot bot merged commit f678c2c into rapidsai:branch-22.02 Dec 7, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Using sparse public API functions from RAFT (rapidsai#4389)
5f5b7aa 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjnolet @ajschmidt8 @codecov-commenter @dantegd @divyegala