Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-format version in docs; allow unanchored version string #4365

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Update clang-format version in docs; allow unanchored version string #4365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The `test` directory has subdirectories that reflect this distinction between th
1. cmake (>= 3.20.1)
2. CUDA (>= 11.0)
3. gcc (>=9.3.0)
4. clang-format (= 8.0.1) - enforces uniform C++ coding style; required to build cuML from source. The packages `clang=8` and `clang-tools=8` from the conda-forge channel should be sufficient, if you are on conda. If not using conda, install the right version using your OS package manager.
4. clang-format (= 11.0.0) - enforces uniform C++ coding style; required to build cuML from source. The packages `clang=11` and `clang-tools=11` from the conda-forge channel should be sufficient, if you are on conda. If not using conda, install the right version using your OS package manager.
5. UCX with CUDA support [optional](>=1.7) - enables point-to-point messaging in the cuML communicator.

### Building cuML:
Expand Down
2 changes: 1 addition & 1 deletion cpp/scripts/run-clang-format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def parse_args():
args.dstdir = tempfile.mkdtemp()
ret = subprocess.check_output("%s --version" % args.exe, shell=True)
ret = ret.decode("utf-8")
version = VERSION_REGEX.match(ret)
version = VERSION_REGEX.search(ret)
if version is None:
raise Exception("Failed to figure out clang-format version!")
version = version.group(1)
Expand Down