Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote FITSNE from experimental #4361

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Promote FITSNE from experimental #4361

merged 3 commits into from
Nov 18, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Nov 12, 2021

Closes #3805

@lowener lowener requested a review from a team as a code owner November 12, 2021 21:29
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 12, 2021
@lowener lowener added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 15, 2021
cjnolet
cjnolet requested changes Nov 15, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your results so far look promising and I think this is almost ready.

python/cuml/manifold/t_sne.pyx Outdated Show resolved Hide resolved
@cjnolet cjnolet added the improvement Improvement / enhancement to an existing function label Nov 15, 2021
cjnolet
cjnolet requested changes Nov 16, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous review didn’t seem to register as requested changes for some reason.

@lowener lowener requested a review from cjnolet November 16, 2021 18:17
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@34f7929). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4361   +/-   ##
===============================================
  Coverage                ?   86.01%           
===============================================
  Files                   ?      231           
  Lines                   ?    18769           
  Branches                ?        0           
===============================================
  Hits                    ?    16144           
  Misses                  ?     2625           
  Partials                ?        0
Flag Coverage Δ
dask 47.04% <0.00%> (?)
non-dask 78.70% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34f7929...50fde97. Read the comment docs.

cjnolet
cjnolet approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Nov 18, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cd6fb7f into rapidsai:branch-21.12 Nov 18, 2021
@zbjornson zbjornson mentioned this pull request Nov 18, 2021
Closed
@lowener lowener deleted the 21.12-promote-fitsne branch February 22, 2022 18:49
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Promote FITSNE from experimental (rapidsai#4361)
b48c4f7 
Closes rapidsai#3805

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Promote FITSNE from experimental
3 participants
@lowener @codecov-commenter @cjnolet