[gpuCI] Forward-merge branch-21.10 to branch-21.12 [skip gpuci] #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provided to FIL model (#4315) Fix potential CUDA context poison due to invalid global read when negative categories provided at inference: now equivalent to non-matching. Same for `+-Inf` categories. NAN categories are still `!def_left`, and fractional categories are truncated (via a typecast), as this is what Treelite does FIL now converts dummy nodes to numerical on import and never generates max_matching == -1 categorical features in test. FIL will still generate empty categorical nodes in test (a non-empty bits vector which contains only zeros), export them as dummy numerical nodes and import again as dummy numerical nodes. If a feature only contains dummy numerical nodes, it will be deemed a numerical feature (same as for non-dummy numerical nodes or a mix thereof). Therefore, categorical feature max_matching == -1 is still prevented.
|
FAILURE - Unable to forward-merge due to conflicts, manual merge is necessary. Do not use the |
github-actions
bot
added
CMake
CUDA/C++
Cython / Python
ajschmidt8
added a commit
that referenced
this pull request
Nov 10, 2021
This PR fixes the logic for when the `nightly` channel should be removed. The change is also incorporated in the forward-merger PR below, but it may take a while to resolve the conflicts there. #4349 Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Ray Douglass (https://github.com/raydouglass) - Jordan Jacobelli (https://github.com/Ethyling) URL: #4350
dantegd
requested changes
Nov 11, 2021
Mark Hellinger sparse test as xfail
ajschmidt8
added a commit
that referenced
this pull request
Nov 17, 2021
Fix forward merge #4349 [skip-ci]
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
This PR fixes the logic for when the `nightly` channel should be removed. The change is also incorporated in the forward-merger PR below, but it may take a while to resolve the conflicts there. rapidsai#4349 Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Ray Douglass (https://github.com/raydouglass) - Jordan Jacobelli (https://github.com/Ethyling) URL: rapidsai#4350
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Fix forward merge rapidsai#4349 [skip-ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-21.10that creates a PR to keepbranch-21.12up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.