Update cub 1.13.1 calls #4334
Closed
Update cub 1.13.1 calls #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
5 - DO NOT MERGE
|
This PR has been labeled |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
The following changes are required for compilation with Thrust 1.15, which is becoming the minimum required version across all of RAPIDS for 22.02. The changes needed: - Removal of global `using namespace std`. This makes calls to `cub::` ambigous as now thrust::cub ( new since 1.14? ) and cub both are valid. - Updates from #4334, which fixes `cub::DeviceSegmentedReduce` signature changes Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #4469
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
The following changes are required for compilation with Thrust 1.15, which is becoming the minimum required version across all of RAPIDS for 22.02. The changes needed: - Removal of global `using namespace std`. This makes calls to `cub::` ambigous as now thrust::cub ( new since 1.14? ) and cub both are valid. - Updates from rapidsai#4334, which fixes `cub::DeviceSegmentedReduce` signature changes Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates calls to account for API changes in CUB 1.13.1 allowing upgrade to thrust 1.13+